Closed wesleytodd closed 5 years ago
Great suggestion, thanks! For your second option, it may in any case be useful to support this. I think I forgot to capture your feedback previously about warnings vs errors, which might help this. Created a ticket to track it: https://github.com/davidcalhoun/eslint-plugin-test-selectors/issues/4
Yeah I ended up just disabling it on all but the main files. Even then I ended up disabling the entire anchor rule and about 10% of the other button and input cases.
Added in 1.1.0
:
disabled
and readonly
are now ignored by default (they can be turned back on in each rule's config - see the readme)plugin:test-selectors/recommended
now emits warnings by default. For the old behavior which emits errors, folks can use plugin:test-selectors/recommendedWithErrors
I think it would be good to exclude elements with
readonly
ordisabled
by default with the ability to turn it on. I am usinginput
's for displaying some non-editable information and this lint rule set errors on them. One other option would be to not error oninput
without anonChange
, but I am not sure which would be better and more robust.