Closed AkashPushkar closed 2 years ago
Thank you for this PR.
I think we would need to add a test for this one... maybe convert the
test.e57
file to spherical, and try to read it back.You can take a look at my other comments too.
Hi David,
I have made the suggested changes and have added unit test for read_scan
and read_header
for spherical case since that is what is changed in the PR.
Instead of using the same test file, I have used test data example (for spherical coordinates) from official site of libe57 (http://www.libe57.org/data.html)
@davidcaron Hi David, Akash made the changes your requested, do you need anything else from us to merge this PR? Thanks!
thank you !
On Fri, Mar 18, 2022 at 5:03 PM David Caron @.***> wrote:
Merged #18 https://github.com/davidcaron/pye57/pull/18 into master.
— Reply to this email directly, view it on GitHub https://github.com/davidcaron/pye57/pull/18#event-6267211777, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADUKZ4TJWSS2HQNDGIQXEU3VASSMTANCNFSM5JYPWNMQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID: @.***>
New feature
Minor bug fixes: In read_scan, invalidCartesianState is used to remove points, only if field is present (https://github.com/davidcaron/pye57/issues/6)