davidcaron / pye57

Read and write e57 point clouds from Python
MIT License
71 stars 41 forks source link

Opening e57 2.3.0 files #32

Open dancergraham opened 1 year ago

dancergraham commented 1 year ago

Hello, I have the same error message as described below when trying to open files saved with e57LibraryVersion E57Format-2.3.0-AMD 64-windows

https://github.com/davidcaron/pye57/issues/6#issuecomment-1346284621

  File "/usr/local/lib/python3.10/site-packages/pye57/e57.py", line 139, in read_scan_raw
    np_array, buffer = self.make_buffer(field, header.point_count)
  File "/usr/local/lib/python3.10/site-packages/pye57/e57.py", line 114, in make_buffer
     raise ValueError("Unsupported point field: %s" % field_name)
 ValueError: Unsupported point field: nor:normalX
dancergraham commented 1 year ago

Opening the file with read_scan(, ignore_missing_fields=True) instead of read_scan_raw works as a temporary workaround for me

SirBob01 commented 4 months ago

Would it be possible to just skip over the unsupported fields (for read_scan_raw) rather than halt reading entirely?

dancergraham commented 4 months ago

Hello yes maybe - I see you closed your PR - did you decide against this approach?

SirBob01 commented 4 months ago

Oh sorry, I meant to create a change for my fork. But I think this is still a good way to go.