search

davidcaron / pye57

Read and write e57 point clouds from Python
MIT License
68 stars 42 forks source link

Upgrade libE57Format to v 3.1.1 #55

Closed dancergraham closed 5 months ago

dancergraham commented 6 months ago

Update to a more recent version of the underlying library

dancergraham commented 6 months ago

for the moment I have removed the variable min max values to get this to compile. I would like to put them back to avoid breaking anybody's code. Ultimately I would like to remove them or put them in a separate namespace to clean up the interface a bit

dancergraham commented 6 months ago

I'm currently stuck with the extensionsLookupPrefix definition (line 501 in libd57_wrapper.cpp) possibly because it is now overloaded - I may need to use the following :

https://pybind11.readthedocs.io/en/stable/classes.html#overloaded-methods

dancergraham commented 5 months ago

Merging like this for now. We still need to add new features and remove outdated ones from the libe57 namespace.