search

davidcaron / pye57

Read and write e57 point clouds from Python
MIT License
71 stars 41 forks source link

feat: add macos support #65

Closed amangupta17 closed 4 months ago

amangupta17 commented 4 months ago

What was the problem/requirement? (What/Why)

pye57 library does not support macOS builds at the moment.

What was the solution? (How)

Updated xerces-c installation as a static dependency which is now referenced by the libe57 binary.

How was this change tested?

sh scripts/install_xerces_c.sh python3 setup.py bdist_wheel

This execution now is able to build a macOS wheel.

Ran: pip install dist/{wheel} import pye57 executes without an error.

dancergraham commented 4 months ago

Awesome thanks for this - I've been wanting to add macos support for some time ! 🍏

dancergraham commented 4 months ago

aiee it looks like something now fails with installing Xerces C on linux

dancergraham commented 4 months ago

I tried to split the install script to fix the linux failure but wheel building is failing on macos for me ... https://github.com/davidcaron/pye57/actions/runs/10098241147/job/27925042195

amangupta17 commented 4 months ago

https://github.com/davidcaron/pye57/pull/67