search

davidcarslaw / openairmaps

mapping functions to support openair
https://davidcarslaw.github.io/openairmaps/
GNU General Public License v3.0
21 stars 6 forks source link

Investigate ggmap alternatives #52

Closed jack-davison closed 6 months ago

jack-davison commented 1 year ago

There is a bug in ggmap related to the brownout of stamenmaps: https://github.com/dkahle/ggmap/issues/353

This leaves ggmap with no way to access map tiles without an API key, which is not very user friendly in a package like openairmaps.

Note to consider ggspatial as an alternative, especially now "sf" is imported for searchNetwork().

jack-davison commented 10 months ago

Reopening this to reinvestigate {ggspatial} as an alternative to ggmap. The current fix was a short term fix to keep {openairmaps} on CRAN.

If we do go with {ggspatial}, we need to decide if we're we're keeping the {ggmap} functionality as an option, or just ripping it out and replacing it with {ggspatial}. If the two will exist in parallel, what will the function names look like (e.g., polarMapStatic2()? Not a huge fan as it's not particularly descriptive!)