search

davidcelis / goodbre.ws

:beers: An example implementation of Recommendable. Unfortunately now defunct.
https://github.com/goodbrews
GNU General Public License v3.0
59 stars 11 forks source link

"Hidden" beers not removed from recommendations #42

Closed adlhancock closed 12 years ago

adlhancock commented 12 years ago

At present I'm getting a lot of recommendations from breweries I know I'm unlikely to be able to get, so have tried to hide these, aiming to get a new load, hoping that at least a couple will be available where I am. The "hidden" icon is highlighting, but the beers are still visible.

davidcelis commented 12 years ago

Yeah sorry bout this dude. There was a bug in v2.0 of the recommendation library that wasn't removing hidden items from possible recommendations. I think that I can fix this manually right now; beers hidden since that update will be removed from recommendations and shouldn't come back. I'll let you know when I finish my hackery and let me know, at that point, if the beers are gone.

davidcelis commented 12 years ago

Done. :+1:? :-1:?

davidcelis commented 12 years ago

Decided to verify it myself, and they seem to be gone. Thanks for reminding me to do that.