search

davidcelis / language-fish-shell

:fish: Atom snippets and syntax highlighting for Fish, the friendly interactive shell.
MIT License
12 stars 4 forks source link

Incorrect highlighting if reserved word appears in hyphenated symbol #11

Open jorgebucaran opened 5 years ago

jorgebucaran commented 5 years ago

In auto-complete, completeshouldn't be highlighted, but is. Same problem with other reserved words or builtin names that appear in a hyphenated symbol. This is just an aesthetic nitpick, but I thought I'd file a bug report. Thanks!

screen shot 2019-01-08 at 20 06 37 
switch "$cmd"
    case auto-complete
        # ...
end
davidcelis commented 5 years ago

@jorgebucaran Thanks for the report! Unfortunately I don't really know how these grammars work, this is just a port that I generated using Atom that's based on the TextMate theme 😓

jorgebucaran commented 5 years ago

@davidcelis No worries! Do you happen to know where I should file the bug? :)

davidcelis commented 5 years ago

I think this place is ok; I'm not even sure that the textmate theme is still maintained. I'm happy to accept a PR that fixes this, so hopefully someone sees the issue and submit a fix!