search

davidcelis / language-fish-shell

:fish: Atom snippets and syntax highlighting for Fish, the friendly interactive shell.
MIT License
12 stars 4 forks source link

Incorrect highliting for $__ #4

Closed ghost closed 8 years ago

ghost commented 8 years ago
screen shot 2016-01-22 at 2 54 04 pm

In this case, $_ is part of the name of the variable $__why and has nothing to do with $_.

davidcelis commented 8 years ago

Agh, that's annoying! Sorry about that! To reiterate what I said in another issue (#1), this is basically just a port of a TextMate theme for personal use and I never took the time to learn the nuances of how the syntax works because it worked well enough for me. I know that's probably a frustrating answer, but I would be willing to work with someone collaboratively on getting these issues fixed or even accepting blind pull requests!

ghost commented 8 years ago

:+1: Roger that.

RSully commented 8 years ago

@davidcelis can you confirm if this is based off of @l15n's tmbundle? I'd like to report this (and the other) issue upstream then.

davidcelis commented 8 years ago

@RSully It is indeed!

nomaed commented 8 years ago

So I guess that this issue is fixed by https://github.com/davidcelis/language-fish-shell/pull/9 I don't know how to associate a pull request with an issue though...

davidcelis commented 8 years ago

@nomaed I can close it out from here 😄 For future reference, GitHub detects things like "Closes #4" or "Fixes #4" and will close out the associated issue automatically.

nomaed commented 8 years ago

Every day, something new ;)