Incorrect handling of escaped characters

[RSully]

Something like this breaks the highlighting:

set -l datafile (eval echo \"$data\")

[ghost]

Yes, so in the meantime, do

set -l datafile (eval echo "\"$data\"")

NOTE: Another example removed because it doesn't work.

[RSully]

I originally tried your second example, but it has different functionality, so it is no good. Your first example does work though:

> set data '$var/thing'
> eval echo \"$data\"
/thing
> eval echo '"$data"'
$var/thing
> eval echo "\"$data\""
/thing

However, obviously I am not going to change my code just for syntax highlighting ;). I'll take a look at the source here and see how difficult it may be to fix.

Also, it appears whatever syntax highlighter GitHub uses for fish also has this same problem. I'm guessing they're both based on the same codebase.

[ghost]

You are right, the second example is bad.

I'm guessing they're both based on the same codebase.

Yeah, I think so too.