search

davidchambers / tutor

JavaScript interface for the Gatherer card database
https://gatherer.wizards.com/
Do What The F*ck You Want To Public License
149 stars 18 forks source link

travis-ci support #64

Closed robdennis closed 11 years ago

robdennis commented 11 years ago

https://travis-ci.org/

it's really useful and helps enforce tests pass on both pull requests and branch development. Recommended.

davidchambers commented 11 years ago

+1

robdennis commented 11 years ago

alright, since I was given push rights to the main repo (thanks), I've added the travis.yml file that I've tested as "valid" but since I'm not a repo admin, I can't do step 1 or 2 of the getting started instructions.

Here's a link to step 1: http://about.travis-ci.org/docs/user/getting-started/#Step-one%3A-Sign-in Here's a link to step 2: http://about.travis-ci.org/docs/user/getting-started/#Step-two%3A-Activate-GitHub-Service-Hook

Alternatively, there may be some sort of administration rights I could be granted that will allow tutor to show up in my github account's repository list, but that seems like a bit much.

davidchambers commented 11 years ago

Thanks! I've turned it on, though I'm not sure it's working. I clicked the "Test Hook" button but haven't (yet) received the promised confirmation email.

davidchambers commented 11 years ago

https://travis-ci.org/davidchambers/tutor/builds/9524166:

WARNING: We were unable to find a .travis.yml file. This may not be what you
  want. Build will be run with default settings.

It looks as though the configuration file's name is expected to begin with a dot.

robdennis commented 11 years ago

yep, hopefully that should do it. What's nice is that I see tutor in my travis console, so I can more easily troubleshoot

edit, it's also a bit more chatty than I'd like since I'm actually making the change through github.com

robdennis commented 11 years ago

alright, build is passing: https://travis-ci.org/davidchambers/tutor/

readme updated with build image, I think that's good enough. Tutor would a good candidate for a nightly build to get advance notice of scraping failures due to a change in gatherer's html, but that's not really supported. Instead, it just runs on commits and (maybe?) pull requests.

there may be a follow on bit of config to make pull requests work right, but we'll see