search

davidchambers / tutor

JavaScript interface for the Gatherer card database
https://gatherer.wizards.com/
Do What The F*ck You Want To Public License
149 stars 18 forks source link

#52 and #69 - attempts to merge in the redirect change from #52 in a more general way to address #69 #70

Closed robdennis closed 10 years ago

robdennis commented 11 years ago

there's a new cli unit test added and I expect that travis will try to validate this pull request

davidchambers commented 11 years ago

I've been following your progress in tracking down the cause of #69. Last night I spent some time rebasing the fix for #52, which wasn't straightforward as we've changed the way we make requests since that fix was made. I should have a pair of pull requests ready to be tested and reviewed within the next few days.

robdennis commented 11 years ago

great. I didn't feel super well-positioned to merge that in, and it was only thanks to the breadth of assertions covered in the unit tests that I felt I got close enough to try it

robdennis commented 10 years ago

Bumping this one on the off chance you were able to knock out the pull requests you mentioned

davidchambers commented 10 years ago

Bumping this one on the off chance you were able to knock out the pull requests you mentioned

I'll see what I can do. :)