search

davidchambers / tutor

JavaScript interface for the Gatherer card database
https://gatherer.wizards.com/
Do What The F*ck You Want To Public License
149 stars 18 forks source link

make gatherer.request's inputs and outputs consistent with those of request itself #74

Closed davidchambers closed 10 years ago

davidchambers commented 10 years ago

When wrapping a function it's nice to provide the same API if possible, and it is possible in this case. Furthermore, exposing the response object will enable the fix for #52 to be resurrected.

robdennis commented 10 years ago

usual caveats about lack of familiarity with the request library, but there's nothing that rings any alarm bells