Closed davidchambers closed 10 years ago
I'm re-running the build in case it's a race condition
not sure this how much better it is, but 2 out of 3 builds pass: https://travis-ci.org/davidchambers/tutor/builds/29781072
node .11/.8 pass, .10 failed for 5000ms timeout, I'll pull locally and run a few times. Feels lame, but bumping the timeout to 10s wouldn't be the worse given that it's still scraping despite it being a fixture.
Looking through the history, it seems like the test for tutor.set extracts hand modifiers
is the one most likely to fail, but it's not immediately obvious if there's a performance problem in the code that's being tested.
assuming it passes, I'll let @davidchambers merge this one in since I made a change to the timeout that I'd like a sanity check on.
Any news on this issue?
The tests are passing; this branch is in a good state. I'd like to fix #86 before merging these changes, though. I hope to do so this weekend.
Awesome. Thanks for the update. Was trying to use tutor to get cards from sets, but they are currently failing, which I guess is what #86 was created for, correct? On Jul 17, 2014 1:54 AM, "David Chambers" notifications@github.com wrote:
The tests are passing; this branch is in a good state. I'd like to fix #86 https://github.com/davidchambers/tutor/issues/86 before merging these changes, though. I hope to do so this weekend.
— Reply to this email directly or view it on GitHub https://github.com/davidchambers/tutor/pull/85#issuecomment-49260940.
Yes (assuming you're hitting the same issue as @robdennis and me).
Yeah, getting set name undefined for all sets. On Jul 17, 2014 2:00 AM, "David Chambers" notifications@github.com wrote:
Yes (assuming you're hitting the same issue as @robdennis https://github.com/robdennis and me).
— Reply to this email directly or view it on GitHub https://github.com/davidchambers/tutor/pull/85#issuecomment-49261270.
Closes #86
This pull request also adds Underscore as a dependency, which simplifies much of the code.