Closed CBXZero closed 8 years ago
Thank you for persevering despite your version control troubles. :)
Please git commit --amend
to give the commit a sensible message. You'll then need to run git push origin master --force
to update this pull request.
Updated the commit and pull request title to be informative :)
That "and" looked weird to me and the build test failed, if this build doesn't work I'll fix it when I can get to my laptop
Tests are failing. ;)
Looking at it on my dev machine now, I'll have it fixed here in a sec :) sorry for the flux of emails you must be getting. D:
Got it that time. I don't know why I thought that "and" looked funny. Then again, I've been studying Statistics all night and that might be messing with me. Lmk if there are any other changes you'd like done. :)
I did some looking into this, and 2 things stood out to me.
I was wondering if there were any ideas that you had that might be causing the issues I'm running into. I'll investigate this issue more tomorrow.
I suggest looking at the differences between the responses to the following requests:
$ curl --silent http://gatherer.wizards.com/Pages/Card/Details.aspx?name=fizzbuzzldspla
$ curl --silent http://gatherer.wizards.com/Pages/Card/Details.aspx?name=test
I'm still looking into this, just haven't been able to come back to it due to an interview and hw. I'll work on it more this next week.
Any luck so far, @CBXZero?
Taking a look at it today, was swamped with schoolwork for a while. I should have something by the end of this weekend.
Spent some time on this during the weekend, the results that I get from curling the URL and the body that I console log when testing are different and that's currently what I'm hung up on.
If you provide a reproducible example of the difference in behaviour between curl
and node
I will help you to investigate. :)
I console.logged the body on the line right before the callback around line 38, pasted it into a test editor, and compared it to the fixture generated and they were radically different. I think there is some recursive call that is throwing me off.
EDIT: I can send you the exact outputs tomorrow afternoon if you want.
Here are the bodies that get logged in order of when I console.log them (this is from a single tutor.card() call searching via name, in this case "test" was used):
https://gist.github.com/CBXZero/b9136fd563b7028e2165
Superseded by #97
First time I attempted the squash, I followed a stackoverflow answer that was misleading. This should be good to go and is all bundled in 1 commit :panda_face: