search

davidchisnall / dtc

FreeBSD Device Tree Compiler
18 stars 15 forks source link

Some cleanup from /omit-if-no-ref/ #51

Closed kevans91 closed 5 years ago

kevans91 commented 5 years ago

As requested by David:

I'm still working through the details of how to tell that a node's being kept alive because of one of its descendants. The two approaches I see at the moment of determining the node's heritage are either a tree walk for each of the nodes we're marking as 'seen' (incredibly not ideal), or storing the path to each node in the tree for comparisons' sake. The latter seems like a more viable option. I'd also need to change the 'used' tracking into more of a ref-count rather than the current single-bit so we can check used == 1 && used_by_descendant, but that's not much of an issue.

davidchisnall commented 5 years ago

I forgot to say, in the last PR, it would be good to update the man page to describe this feature and possibly bump the GPL dtc compatibility version in the about message.

kevans91 commented 5 years ago

I believe I've addressed your outstanding requests.

davidchisnall commented 5 years ago

Please can you update the man page and the GPL dtc version that we report compatibility with in the version message?

kevans91 commented 5 years ago

Please can you update the man page and the GPL dtc version that we report compatibility with in the version message?

Crap, sorry, I missed that. =( Where do you think it best fits in the man page? I'm struggling to decide if it should go in "Standards" (to note that it's not standard, will delete your cats, etc.) or elsewhere.

davidchisnall commented 5 years ago

I'd probably add a new section for the man page to describe the new feature.