Force return_format=CSV

davidclarance / rabm

The `rabm` package provides an interface to the Africa Bird Atlas data.

https://davidclarance.github.io/rabm/

3 stars 1 forks source link

Force return_format=CSV #17

Open Rafnuss opened 4 years ago

Rafnuss commented 4 years ago

JSON is actually not currently supported. From what I understand, it doesn't bring any advantages compared to CSV. Consequently, I would remove it from the function arguments and documentation

Which do you prefer?

# return_format only support CSV
  return_format <- 'CSV'

"http://api.adu.org.za/sabap2/v2/R/{start_date}/{end_date}/{region_type}/{region_id}/{return_type}/species/{species_id}?format=CSV"

Rafnuss commented 4 years ago

I am in favor of the second option. Already implemented for get_species_list

davidclarance commented 4 years ago

Yeah agree, the second solution makes the most sense. Thanks for implementing. Will implement in all the other functions once I do a clean up.