davidclemens / Dingi

Dingi is a toolbox for processing data collected by marine research gear.
MIT License
1 stars 0 forks source link

Improve performance of `DataKit.enum` validation methods #148

Closed davidclemens closed 1 year ago

davidclemens commented 1 year ago

Current Implementation

The getSubclasses method is very slow but called many times, especially by DataKit.enum.validateClassName.

Suggested Enhancement

Don't look for all subclasses in DataKit.enum.validateClassName. Just check if the class exists using the meta.class.fromName method.

Expected Benefits

Improved performance.

Is this something you're interested in working on

Yes.