davidcsterratt / RTriangle

Port of the Triangle Two-Dimensional Quality Mesh Generator and Delaunay Triangulator to R
https://cran.r-project.org/package=RTriangle
9 stars 4 forks source link

Function declaration without prototype is deprecated #18

Closed davidcsterratt closed 1 year ago

davidcsterratt commented 1 year ago

The CRAN maintainers have let me know about the following warnings on: https://cran.r-project.org/web/checks/check_results_RTriangle.html They need to be fixed, otherwise RTriangle will be removed from CRAN.

Version: 1.6-0.10
Check: whether package can be installed
Result: WARN
    Found the following significant warnings:
     ./triangle.h:287:17: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
     ./triangle.h:288:13: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
     interface.c:28:6: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
     interface.c:249:14: warning: passing arguments to 'triangulate' without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
     triangle.c:1372:5: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
     triangle.c:1419:6: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
     triangle.c:1434:7: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
     triangle.c:1455:6: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
     ./triangle.h:288:6: warning: a function declaration without a prototype is deprecated in all versions of C and is treated as a zero-parameter prototype in C2x, conflicting with a subsequent definition [-Wdeprecated-non-prototype]
     triangle.c:3284:19: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
davidcsterratt commented 1 year ago

Now fixed, and on its way to CRAN.