search

davidcsterratt / retistruct

Computational reconstruction and transformation of flattened retinae
http://davidcsterratt.github.io/retistruct/
7 stars 7 forks source link

issue with adding tears in retistruct #11

Closed sagewiltse closed 7 years ago

sagewiltse commented 7 years ago

After some issues with downloading the retistruct package onto my Mac, we were able to go through until it came to opening the outline.roi in retistruct. I was able to open the outline, but it wouldn't let me add a tear or indicate nasal. I am working with Brian Cohn and he said to come here. Let me know and any help is appreciated.

screen shot 2017-06-16 at 11 50 48 am screen shot 2017-06-16 at 11 54 18 am
briancohn commented 7 years ago

@sagewiltse please upload your outline.roi as well

davidcsterratt commented 7 years ago

Hmm.... That's interesting. The outline.roi file would be useful. Also, after you get the error, could you type "traceback()" in the R console, and send me the output please?

sagewiltse commented 7 years ago

Here is what I got when I typed in "traceback()" and the outline.roi file. Let me know your thoughts, and I appriciate the help.

-Sage Wiltse

On Mon, Jun 19, 2017 at 10:01 AM, David C Sterratt <notifications@github.com

wrote:

Hmm.... That's interesting. The outline.roi file would be useful. Also, after you get the error, could you type "traceback()" in the R console, and send me the output please?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/davidcsterratt/retistruct/issues/11#issuecomment-309502800, or mute the thread https://github.com/notifications/unsubscribe-auth/AcH_EYqu54nlsFNYbh7iIuu4t-cDna6Wks5sFqlngaJpZM4N80AA .

davidcsterratt commented 7 years ago

I can't see the output on the github website - please could you try posting it again.

davidcsterratt commented 7 years ago

I think this might be fixed in the next version of Retistruct, 0.5.11, which I am working on now.

sagewiltse commented 7 years ago

Here is the output. Thank you for your help!

screen shot 2017-06-19 at 10 07 48 am
briancohn commented 7 years ago

@davidcsterratt what do you think? which functions/libraries are most likely responsible for this issue? perhaps you could push the redistrict new version as a development branch on GitHub?

briancohn commented 7 years ago

@davidcsterratt Many of our retina package users are getting blocked in trying to use retistruct in our package. Could you please publish a version of retistruct that does not include the graphic user interface, and with no dependencies to gWidgets, RGTK2, etc?

Brian

davidcsterratt commented 7 years ago

Hello Brian, sorry for the delay getting the latest version of Retistruct onto CRAN. I have been having problems because of getting the RTriangle package to compile on Windows x86 (#14). Are you sure it's RGTk that is blocking users or RTriangle?

In any case the current stable version (0.5.10) doesn't actually depend on RGK2, gWidgets &c; these are "Suggests", so users should still be able to install Retistruct without installing the other packages. They are only installed when the GUI is started using retistruct(). If you can mark up a retina without using the interface, then retisturct.reconstruct(directory_name) can be called to reconstruct the retina from the files in directory_name.

The current development version is available to download from GitHub on the master branch, and this should fix the problem here. It should work now that #13 has been fixed by a change to gWidgets2.

Apologies again - there is a bit of dependency hell at the moment!

davidcsterratt commented 7 years ago

I've managed to get Retistruct on CRAN, so you should be able to install it using: install.packages("retistruct") You may also need install.packages("gWidgets2RGtk2") Also, you may need to wait a day or two for this to work for Windows, as it takes a while for CRAN to build the packages and for them to reach mirrors.