davidcsterratt / retistruct

Computational reconstruction and transformation of flattened retinae
http://davidcsterratt.github.io/retistruct/
7 stars 7 forks source link

Allow passing of verbose parameter #22

Closed bc closed 5 years ago

bc commented 6 years ago

https://github.com/davidcsterratt/retistruct/blob/63ddb4719ca3f9759f7ea26c490795a04944563c/pkg/retistruct/R/spheristruct.R#L740

https://github.com/davidcsterratt/retistruct/blob/master/pkg/retistruct/R/spheristruct.R#L852

thanks!

davidcsterratt commented 6 years ago

I'm not clear what the issue is here - could you give a bit more explanation please?

bc commented 6 years ago

sure - there's no way to stop this from printing image

So i end up with hundreds of these:

image

because there's no parameter that I can pass through that will kill the print message. This is the case for 2 functions: image

image

Ideally everything would be non-verbose by default, unless the users want to critically evaluate the stitching/FIRE, etc.

bc commented 6 years ago

this is in my package:

##' @title Retistruct Wrapper
##' @description
##' Reads in the folder, reconstructs, and returns the retinal object.
##' @param path string path to the folder with retinal data.
##' @return rad Retinal data in radian units.
##' @author Brian Cohn \email{brian.cohn@@usc.edu}
##' @references Sterratt et. al. 2013
##' @importFrom retistruct retistruct.read.markup retistruct.reconstruct retistruct.read.dataset
##' @export
dss_retistruct_processing <- function(path) {
    do_not_print <- function(string) {
    }
    rad <- retistruct.read.markup(retistruct.read.dataset(path))
    rad <- retistruct.reconstruct(rad, report = do_not_print, plot.3d = FALSE)  ## Reconstruct (computation intensive)
    return(rad)
}

For the function retistruct.reconstruct I'd like to be able to pass it a quiet=TRUE parameter, or something that will propagate all the way down to solveMappingCart & optimiseMapping.

bc commented 6 years ago

thank you!

bc commented 5 years ago

thank you!!