daviddarnes
commented
4 years ago This is great, thanks @studioromeo! Love that they, and you, changed it to something more semantic. 13 is almost arbitrary in meaning, Enter is actually readable
Closed studioromeo closed 4 years ago
daviddarnes
commented
4 years ago This is great, thanks @studioromeo! Love that they, and you, changed it to something more semantic. 13 is almost arbitrary in meaning, Enter is actually readable
On the search page there's usage of some keyboard events that are now deprecated and could be removed from future browsers.
keyCodeis deprecated in favour of code & key. We use key as we care about the value of the key rather than it's physical position. (https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode)keypressis a deprecated event in favour of keydown which represents the same thing but isn't deprecated. (https://developer.mozilla.org/en-US/docs/Web/API/Document/keypress_event)The javascript is pretty much the same as before so this should be ok for people to port into their themes that used this as a boilerplate.