search

daviddarnes / alembic

⚗️ A Jekyll boilerplate theme designed to be a starting point for any Jekyll website
https://alembic.darn.es
MIT License
754 stars 894 forks source link

[Fix] Slugify categories in metadata #174

Closed jimgraham closed 3 years ago

jimgraham commented 3 years ago

Fixes #173

I've added an example ("My favourites" "External sources") to the example blog pages. However, I'm not sure where to add a proper test for this fix. I would really appreciate any advice on where to add an appropriate test.

daviddarnes commented 3 years ago

Hey @jimgraham, thanks for spotting this bug and providing a fix! Can't believe I've missed this one, but thankfully not too painful to solve. Only change I see that might be better is to change the example category to "External sources" and mark the "Description of an Alembic" and "History of the Alembic" with that new category? I like to keep the example content as logical as I can for people trying to understand the usage of the theme. Since both of those articles are lifted from Wikipedia is makes sense to put them in an external sources category. Hope that's ok 😊

jimgraham commented 3 years ago

Thanks for the response! Are there any unit tests I should provide? Didn't see a test/ directory.

daviddarnes commented 3 years ago

@jimgraham sadly not but there should be really 😅 Looks good though! Merging now