daviddarnes / alembic

⚗️ A Jekyll boilerplate theme designed to be a starting point for any Jekyll website
https://alembic.darn.es
MIT License
767 stars 903 forks source link

[Bug]: deprecation of slash character as division #191

Open DonVito1982 opened 1 year ago

DonVito1982 commented 1 year ago

Summary

Sass deprecated the use of the slash character / as division sign in 1.3.3 and such use of the character will be removed in Sass 2.0.0. See Breaking changes announcement. Therefore *.scss files should be updated accordingly

To Reproduce

Steps to reproduce the behaviour:

  1. Serve a jekyll blog that uses alembic as remote theme
  2. Confirm that deprecation warnings appear while building the site

Expected behaviour

The site should be built without warnings.

Sample warning

Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($get-size, nth($sizes, 1)) or calc($get-size / nth($sizes, 1))

More info and automated migrator: https://sass-lang.com/d/slash-div

    ╷
197 │       font-size: #{$get-size / nth($sizes, 1)}rem;
    │                    ^^^^^^^^^^^^^^^^^^^^^^^^^^
    ╵
    /tmp/jekyll-remote-theme-20231114-921773-fxtmqz/_sass/sassline-base/_mixins.scss 197:20       fontsize()
    /tmp/jekyll-remote-theme-20231114-921773-fxtmqz/_sass/sassline-base/_typography.scss 14:3     @import
    /tmp/jekyll-remote-theme-20231114-921773-fxtmqz/_sass/_sassline-base.scss 6:9                 @import
    alembic.scss 7:3                                                                              @import

Environment