davidde / mpv-autosub

Fully automatic subtitle downloading for the MPV media player
https://mpv.io/
MIT License
295 stars 42 forks source link

Needs function to download alternate subs if first file is no good #14

Closed Rabcor closed 3 years ago

Rabcor commented 3 years ago

Sometimes this script will download subs that are bad, for instance I have this movie, white snake, and the downloaded sub for it is White.Snake.2019.1080p.BluRay.x264.AAC5.1-[YTS.LT].en.srt

It's (entire) content:

`1
00:00:30,000 --> 00:00:36,000
Provided by YTS.LT

2
00:00:36,500 --> 00:00:42,000
Find the official YIFY movies site at
https://YTS.LT

3
00:30:30,000 --> 00:30:36,000
Downloaded from YTS.LT

4
01:00:30,000 --> 01:00:36,000
Download more movies for free
from YTS.LT
`

Nevermind being a mistimed subtitle file, it's just not a real subtitle at all.

I'd like to have the ability to press a key that makes it look for an alternative subtitle file instead of the one it first downloaded.

Additionally or perhaps alternatively(?) an automated feature that checks if the filesize of the subtitle file is at least over 1kb and rejects the file if it isn't to prevent this specific scenario might be nice.

davidde commented 3 years ago

Duplicate of #9

davidde commented 3 years ago

Request belongs here: https://github.com/Diaoul/subliminal/issues/new

Also, subtitle files like that should be flagged and removed on the provider's end.

Rabcor commented 3 years ago

Request belongs here: https://github.com/Diaoul/subliminal/issues/new

Also, subtitle files like that should be flagged and removed on the provider's end.

In a perfect world; of course the provider would handle that ;)

Sorry for the duplicate.

davidde commented 3 years ago

No worries.

Wish I could fix this on my end.