search

daviddesberg / PHPoAuthLib

PHP 5.3+ oAuth 1/2 Client Library
Other
1.08k stars 454 forks source link

Namespace issue #488

Closed typoworx-de closed 8 years ago

typoworx-de commented 8 years ago

Some files abuse the php-namespace conventions. Usually the Namespace should be the first after php-tag. Some files have the namespace preceeding with two linebreaks breaking the functionality of PSR-4 Autoloader.

Example: OAuth/Common/Http/Uri/UriFactory.php

<?php

namespace OAuth\Common\Http\Uri;

use RuntimeException;

It should look like this:

<?php
namespace OAuth\Common\Http\Uri;

use RuntimeException;
PeeHaa commented 8 years ago

Some files abuse the php-namespace conventions.

What files and what "php-namespace" conventions?

Usually the Namespace should be the first after php-tag. Some files have the namespace preceeding with two linebreaks breaking the functionality of PSR-4 Autoloader.

PSR4 says nothing about linebreaks (nor does PSR0) AFAIK. And it certainly won't break the functionality of PSR-4 Autoloader.

Do you have a specific issue? Because it feels to me that you are asking about a problem without explaining the actual problem.