search

daviddesberg / PHPoAuthLib

PHP 5.3+ oAuth 1/2 Client Library
Other
1.08k stars 454 forks source link

Facebook client now attempts to decode responseBody first, then falls… #511

Closed lettucedeep closed 7 years ago

lettucedeep commented 7 years ago

… back to parse_str if the decode is not successful.

nickryall commented 7 years ago

@lettucedeep Why was this one was closed? I am running into this issue also and your fix appears to solve it.

lettucedeep commented 7 years ago

@nickryall It seems that this issue is already fixed. For some reason, when I was inspecting the source and when I cloned, I was looking at v3.6, which didn't have that commit.

If you're using oriceon/oauth-5-laravel, that package's version requirement for Lusitanian/PHPoAuthLib was set from ~0.3, where it had been for a while, to ^0.3 then to 0.* in the last few days.

If you run a composer update oriceon/oauth-5-laravel --with-dependencies, you should get the latest version of Lusitanian/PHPoAuthLib with the required changes. :)

nickryall commented 7 years ago

Great. Thanks for the help :1st_place_medal: