search

daviddesmet / paseto-dotnet

🔑 Paseto.NET, a Paseto (Platform-Agnostic Security Tokens) implementation for .NET
MIT License
101 stars 8 forks source link

Please add DateTimeOffset overloads #135

Closed grosch closed 2 months ago

grosch commented 2 months ago

For all of the things like IssuedAt that take a DateTime, would you please add an overload that takes a DateTimeOffset?

grosch commented 1 month ago

@daviddesmet I see you merged this, thanks, but it doesn't look like you push a new release to NPM

daviddesmet commented 1 month ago

@grosch oh yeah, I forgot to push the draft release. It will be available in a couple of minutes at NuGet.org To mention, you can always grab the latest version from here: https://github.com/daviddesmet/paseto-dotnet/pkgs/nuget/Paseto.Core

It helps to test the latest build before it gets promoted to NuGet.org

grosch commented 1 month ago

For my packages I created a workflow that runs on release of type published so that when I create a release it automatically publishes to NuGet. I stored a nugget api key in the repo secrets and then the workflow just does a dotnet nugget push with appropriate flags.

daviddesmet commented 1 month ago

Yeah, the workflow does run similarly to what you mentioned. It creates a draft release with the merged PRs and closed issues, and then when you move the draft to publish it triggers the Nuget push. You just need to publish the release whenever you feel appropriate. I like it this way since you have more control over things.