search

daviddeutsch / yt-sanegrid

YouTube abandoned the subscription grid view. This has made a lot of people very angry and been widely regarded as a bad move.
http://daviddeutsch.github.io/yt-sanegrid/
GNU General Public License v3.0
37 stars 10 forks source link

Not remembering watched/muted video's. #130

Open ditmarvisser opened 10 years ago

ditmarvisser commented 10 years ago

I'm on the latest chrome version. Whenever i refresh the page or browser every video just gets shown again.

daviddeutsch commented 10 years ago

Are you sure you're not in incognito mode?

ditmarvisser commented 10 years ago

100% sure. It's been happening for the last few days now. I did recently put it as a startup page. Maybe that has something to do with it.

daviddeutsch commented 10 years ago

Well, the problem is that I'm 100% sure I didn't change anything to the app in... quite a while.

Very weird. Can you try whether it's the same for you in some other browser?

ditmarvisser commented 10 years ago

In firefox it just works like it should. I will try unsetting it as a startup page.

ditmarvisser commented 10 years ago

Nope, disabling it as a strartup page did nothing. Maybe it has something to do with the fact that it has over 6000 videos in it's cache?

daviddeutsch commented 10 years ago

Wait a sec - so the videos are there, but they lack the watched flag? The flags are stored in the video list! The only thing I can imagine happening here is that you are indeed maxing out your localStorage limit... Seems like the limit is 5MB for Chrome.

Do you also have a problem in general with adding new items onto the list?

daviddeutsch commented 10 years ago

Can you also run this for a test? https://arty.name/localstorage.html

ditmarvisser commented 10 years ago

It doesnt load more than 40 'new' videos, after that it goes back 9 days ago, which is when this problem started. The test results are this: 5200000 characters were stored successfully, but 5300000 weren't.

daviddeutsch commented 10 years ago

Just did the math on this - a video entry averages around 450 characters. At 6k entries, that's 2.7m characters in total. Still only halfway to the 5.3m limit, but I think it's reasonable to assume that hitting some kind of limit may play a role here.

Only short-term thing I can think of is to limit the total number of videos. For the long term, the move to new browser based database tech is planned.

ditmarvisser commented 10 years ago

Is there something i can do right now? Or do i have to wait for you to update the page?

ditmarvisser commented 10 years ago

The localstorage file is actually 10 mb. http://i.imgur.com/0Zh7pcY.png?2

daviddeutsch commented 10 years ago

Wow, that explains it, actually. I will try to get an option to erase old videos quickly. But this won't be properly fixed until I move the storage mechanism from localStorage to WebSQL/IndexedDB.

daviddeutsch commented 10 years ago

Oh and: Thanks for investigating, sorry for the problems.

eadslab commented 10 years ago

Aha! I dropped in wondering about exactly this issue, and it's comforting to see that I'm not alone. It's been happening to me as described here, in Firefox 27.0.1, and in Opera 12.16.

Firefox shows new videos only going back one day, then skips back to old videos, from 23 days to over a month old. It's "Showing 300 of 6101 entries." The current day's watched videos do seem to mark as watched and stay watched, but it's impossible to clear the old ones, and they seem to keep piling up, preventing me from keeping track of the most recent few days to a week or so. Those unwatched recent videos are, apparently, overwritten by the old "stuck" ones from last month.

Same symptoms in Opera, but not as radical. It goes back 2 days, then jumps to videos from two weeks to a month ago. I've only been using Sanegrid with it for about a month off and on, since it started acting up in Firefox. It's "Showing 300 of 519 entries."

I've actually had to resort to using gasp YouTube's awful excuse for a "Feed," to catch videos from a few days ago that I'd put off watching. And that definitely sucks.

eadslab commented 10 years ago

Followup: Last night I went through and marked, again, every one of the old watched videos as watched. They, and all of the videos I watched yesterday, vanished. Twenty hours later, I just now loaded Sanegrid for tonight's viewing session, and every one of the old videos is back, along with all of yesterday's. And there's the same void between yesterday's videos and the ones that are 24 days old.

eadslab commented 10 years ago

Any relief in sight? It's still not remembering watched videos at all, and regardless of what number I set for the display (100, 200, 500), I get exactly 50 of the latest videos, representing less than a day. At that point it starts showing old videos that are now pushing 3 months old and beyond, up to whatever limit I've set. They absolutely won't go away, and at the bottom of the page it says, "Showing xxx of 6100 entries." Anything I can do to unstick this?

eadslab commented 10 years ago

So there's no way I can reset this? Restore it to ground zero and start over? I'm currently showing 6100 videos, 6050 of which date from 3 months old to the beginning of time. The remaining 50 are less than a day old, and those 50 are the only recent videos showing. The old ones are constantly overwriting them, and not a one of them remains marked as watched after a reset. It's down to the point where I've given up trying to use it, and I have no clue how to make it work again, short of a "format c:", and I'm not even sure if that would fix it.