search

daviddeutsch / yt-sanegrid

YouTube abandoned the subscription grid view. This has made a lot of people very angry and been widely regarded as a bad move.
http://daviddeutsch.github.io/yt-sanegrid/
GNU General Public License v3.0
37 stars 10 forks source link

Issue with clicking video if hide watch is checked #35

Closed nickbrooking closed 11 years ago

nickbrooking commented 11 years ago

If the Hide Watched box is checked, when you click a video it disappears and the next video in line is the one that gets clicked instead. The order of the two events is probably wrong, it should load the video then disappear instead.

daviddeutsch commented 11 years ago

Wow, good find. Will investigate.

daviddeutsch commented 11 years ago

Fixed in next push (live in a couple of minutes).

nickbrooking commented 11 years ago

This issue seems to be back again now, just happened to me.

daviddeutsch commented 11 years ago

Yeah, I switched to angular-based filtering. Should have tested whether this one was back, but was too tired at 3am last night :wink: Will see what I can do for this, I'll probably just have to wrap the linking some way or another, although I don't like that option since it somewhat breaks the pure html approach.

daviddeutsch commented 11 years ago

Dang, now it opens videos twice. That's no good.

Chrisseh commented 11 years ago

Videos are no longer opening when clicked, however they are marked as watched and therefore become hidden.

nickbrooking commented 11 years ago

Yes I'm having the same issue now as well.

daviddeutsch commented 11 years ago

Works fine on my end. Can you try reloading the page?

Chrisseh commented 11 years ago

Yeah I've tried clearing all cache etc and starting and the same still happens. Videos open fine when "Hide Watched" is unchecked but don't open when watched videos are hidden.

nickbrooking commented 11 years ago

Still happening for me as well. You click the video, it disappears, and nothing opens.

Chrisseh commented 11 years ago

I'm using Chrome if that makes any difference..

daviddeutsch commented 11 years ago

I'm testing on both Firefox and Chrome/Chromium and both work just fine for me.

I've just pushed a change - it now uses href= instead of ng-href= (which doesn't make much sense if it's already in an ng-repeat, anyhow). Let me know if that fixes anything for anybody.

Chrisseh commented 11 years ago

Not sure if it takes a while for the pushed changes to take effect but it's still the same on my end unfortunately. Disabled all extensions on chrome too to make sure it wasn't some sort of conflict and the problem still persists.

daviddeutsch commented 11 years ago

Dang and double dang. Trying another thing - should be live in about 10 minutes.

daviddeutsch commented 11 years ago

Change is live now. Still working for me in FF and Chrome

Chrisseh commented 11 years ago

So strange. It's still the same for me. Tested on Chrome, Firefox and Safari. It was working perfectly yesterday from what I can remember!

nickbrooking commented 11 years ago

Works for me about one in four or five times. Try it on a big list.

On Mon, Aug 26, 2013 at 3:06 PM, David Deutsch notifications@github.comwrote:

Change is live now. Still working for me in FF and Chrome

— Reply to this email directly or view it on GitHubhttps://github.com/daviddeutsch/yt-sanegrid/issues/35#issuecomment-23286902 .

daviddeutsch commented 11 years ago

This is nuts, you guys. Now I have it occasionally not working as well. WHAT!?

Chrisseh commented 11 years ago

Yeah it sometimes works for me too very occasionally. Usually when I switch watched videos from visible to hidden... It'll work for one video then go back to not working. So strange.

nickbrooking commented 11 years ago

There is some kind of timing issue going on it seems like.

On Mon, Aug 26, 2013 at 4:47 PM, David Deutsch notifications@github.comwrote:

This is nuts, you guys. Now I have it occasionally not working as well. WHAT!?

— Reply to this email directly or view it on GitHubhttps://github.com/daviddeutsch/yt-sanegrid/issues/35#issuecomment-23293343 .

daviddeutsch commented 11 years ago

That's what I'm thinking as well. I had it changed around so that it's now just a pure link that has an ng-mousedown attached which marks the video as watched. Going with mousedown was my choice because that would mean it's triggered just before the link opens up the new window. Adding in the new transitions thing, we have a nice timing window there where everything should go smoothly. But it doesn't. Hmmm. Maybe I'll try some other mouseevents - might be that mousedown is just buggy or not performing the way I imagine it should perform.

daviddeutsch commented 11 years ago

For now, it seems like going with mouseup instead of mousedown is the way to go. Clicked around a bit and didn't run into any problems so far (but we've been there before...).

Chrisseh commented 11 years ago

Yup! That seems to have sorted it for me :) Every video is now popping up as it should and hiding the relevant thumbnail. Good job!

daviddeutsch commented 11 years ago

Sweet! Let's see if anybody else complains, otherwise - phew!

nickbrooking commented 11 years ago

Working 100% for me now as well, thanks!

On Tue, Aug 27, 2013 at 12:42 AM, David Deutsch notifications@github.comwrote:

Sweet! Let's see if anybody else complains, otherwise - phew!

— Reply to this email directly or view it on GitHubhttps://github.com/daviddeutsch/yt-sanegrid/issues/35#issuecomment-23312787 .

daviddeutsch commented 11 years ago

Awesome! Closing now, until I'll reopen it in a week or so, I guess.