daviddeutsch / yt-sanegrid

YouTube abandoned the subscription grid view. This has made a lot of people very angry and been widely regarded as a bad move.
http://daviddeutsch.github.io/yt-sanegrid/
GNU General Public License v3.0
37 stars 10 forks source link

Change error handling to account for youtube issues. #66

Open warcode opened 10 years ago

warcode commented 10 years ago

Check videocache for existing videos to show videos to the user if Youtube has returned them at some point.

The chances of a user re-privatizing subscriptions is much smaller than youtube failing at APIs.

@@ -103,9 +103,9 @@ ytsubgridApp.controller( 'AppRepeatCtrl',
             }
           } );
         }
      } else if ( code == 403  && $scope.videocache.length <= 0) {
         $scope.forbidden = 1;
      } else if ($scope.videocache.length <= 0) {
         $scope.notfound = 1;
      } else {
        //Show videos, but show error/warning toast to user
      }

@@ -123,10 +123,10 @@ ytsubgridApp.controller( 'AppRepeatCtrl',

           checkData();
         }
      } else if ( code == 403 && $scope.videocache.length <= 0) {
         $scope.start = true;
         $scope.forbidden = 1;
      } else if ($scope.videocache.length <= 0) {
         $scope.start = true;
         $scope.notfound = 1;
       } else {
        //Show videos, but show error/warning toast to user
      }
daviddeutsch commented 10 years ago

Woops, didn't see this before opening #67 - will keep it open for reference.