Closed CristianHenzel closed 10 years ago
Blargh. Just noticed, after submitting the pull request, that the actual proper css is in less/ytgrid.less. You want me to create a new pull request with the proper file edited?
Uhm, actually I separated those files for a reason - so that I wouldn't have this one huge html file to deal with - with all the extra syntax for angular, things can get a little complicated. It also slightly reduces loading time, although that's not a big factor.
And yeah, the less file auto-compiles into css in my IDE. What did you want to change there?
Well, IMHO, this approach would be better, especially for mobile devices, or devices with smaller screens, since you would only have a single button on the actual page, and everything else would be tucked away in that modal window. If you want, I could try and create a new pull request with the same approach (single window for all settings) but where the tabs get pulled in via ajax. Then you would still have everything in separate html files, but with the benefits of having less clutter on the page, and everything being a bit neater organized.
P.S. Load time isn't really influenced unless you open the settings window, since that's where all the other code is now.
Should be fine now. You can see the result of this at http://shantzu.github.io/yt-sanegrid/ If you want me to rewrite it to pull the tab contents in via ajax from separate html files, like it was before, just let me know.
No, I get what you're trying to achieve there - it's just that I don't want to have everything in one file. The other thing is that for non-mobile, the interface with the footer does make sense, so it would need to be adaptive. I'll figure something out.
Well, if you want I can recreate the pull request to pull the contents of the tabs from the html files via ajax. Then you could just create 2 separate footers, one with just the settings button, for mobile, and then "full" footer for desktop, and then maybe load the corresponding footer according to resolution, or device or whatever.
The thing is, I would probably want to do the stuff via CSS, which is reasonably straightforward in bootstrap. I think I have an idea, give me a minute to try it out.
New solution looks good, I'll close this now.
Sweet!
Unified the footer, channels, filters, support and updates all into a single window, only thing left to do should be some visual tweaking to your liking. I removed the duplicate code, consisting of the channels.html, filter.html, support.html and updates.html, but I didn't remove the -- now unnecessary -- css stylings from ytgrid.css because, no offence :smile:, that file is a mess.