daviddias / webrtc-explorer

:earth_africa: P2P Network Routing Overlay designed for the Web platform (browsers)
MIT License
288 stars 32 forks source link

Some Trickle ICE related issues #4

Open areiter opened 9 years ago

areiter commented 9 years ago

Commit https://github.com/diasdavid/webrtc-explorer/commit/a5a3a785a6acbed2eb76f7acba83f08bc6fa5cbe removes bows and updates , as it's not compatible with node, everything else seems also to work with nodejs.

Sorry, there are also some other nodejs related changes incorporated.

daviddias commented 9 years ago

Hi @areiter , thank you for showing up and contributing.

Could you explain me a bit more about "removing bows because it is not compatible with node"? webrtc-explorer was built to run on the browser.

daviddias commented 9 years ago

I see that your goal is to have WebRTC explorer working both in the browser and in Node.js? That's pretty cool.

Have you looked at the Signalling Server? It is the rendezvous point for WebRTC peers to connect between themselves - https://github.com/diasdavid/webrtc-explorer-signalling-server

areiter commented 9 years ago

I'm aware of the signalling server as an integral part of the system. As you noticed several times, my goal is to have it running in node-js. Your main goal is to support browsers, although maybe some of the changes are also relevant for you.

From my point-of-view, an ideal solution would be to have a single module, running in the browser and in the node environment.

daviddias commented 9 years ago

From my point-of-view, an ideal solution would be to have a single module, running in the browser and in the node environment.

I agree, and if we can work together on that, I'm all aboard. Nevertheless, I should inform you, that if you are looking for DHT for Node.js only, you probably don't want to use webrtc-explorer or webrtc at all, you could avoid all of the signalling stuff or even having to have several Data Channels open, since dealing a socket is way cheaper.

daviddias commented 9 years ago

I opened a issue of where to go next - https://github.com/diasdavid/webrtc-explorer/issues/5

areiter commented 9 years ago

Browser <--> Node interoperability would be really nice :-)