search

daviddoria / vtkOBJWriter

vtkOBJWriter
Apache License 2.0
9 stars 8 forks source link

Removed ";" from vtkmacro setups to avoid pedantic errors in the downstream codes #6

Closed ahmadhasan2k8 closed 6 years ago

daviddoria commented 6 years ago

Can you please separate the style/formatting changes from the removal of the semi-colon? I'm happy to also accept the style changes (separately) if they are more conformant to current VTK style.

ahmadhasan2k8 commented 6 years ago

It's my sublime. Whenever I save file it formats everything according to clang format. I have made some other changes which is conforming to the current VTK style I believe which I will submit as a pull request later. I will separate the removal of semi-colons for now. Thanks

ahmadhasan2k8 commented 6 years ago

Should be corrected now.

daviddoria commented 6 years ago

Thanks!

David

On Thu, Dec 14, 2017 at 5:34 PM, ahmadhasan2k8 notifications@github.com wrote:

Should be corrected now.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/daviddoria/vtkOBJWriter/pull/6#issuecomment-351868599, or mute the thread https://github.com/notifications/unsubscribe-auth/AANID1wdDkegpIu32nllSi7GEa0BezINks5tAbB-gaJpZM4RCy4m .

ahmadhasan2k8 commented 6 years ago

Thanks