davide-scalzo / react-native-mixpanel

A React Native wrapper for Mixpanel tracking
MIT License
455 stars 195 forks source link

Support RN56: Use compileSdkVersion & buildToolsVersion from project if set #147

Closed drew-r closed 6 years ago

drew-r commented 6 years ago

Fixes

The SDK Build Tools revision (23.0.1) is too low for project ':react-native-mixpanel'. Minimum required is 25.0.0

ghost commented 6 years ago

DeepCode found the following issues:

Critical: 0 Warning: 0 Info: 0

Priority breakdown:

Security Defect API Anomaly Rename Lint Info
Critical 0 0 0 0 0 0 0
Warning 0 0 0 0 0 0 0
Info 0 0 0 0 0 0 0

Most affected files:

File Critical Warning Info

See detailed analysis.

ghost commented 6 years ago

DeepCode found the following issues:

Critical: 0 Warning: 0 Info: 0

Priority breakdown:

Security Defect API Anomaly Rename Lint Info
Critical 0 0 0 0 0 0 0
Warning 0 0 0 0 0 0 0
Info 0 0 0 0 0 0 0

Most affected files:

File Critical Warning Info

See detailed analysis.

ghost commented 6 years ago

DeepCode found the following issues:

Critical: 0 Warning: 0 Info: 0

Priority breakdown:

Security Defect API Anomaly Rename Lint Info
Critical 0 0 0 0 0 0 0
Warning 0 0 0 0 0 0 0
Info 0 0 0 0 0 0 0

Most affected files:

File Critical Warning Info

See detailed analysis.

ethanneff commented 6 years ago

similar to my solution. can we get this PR deployed?

apply plugin: 'com.android.library'

def _ext = rootProject.ext
def _compileSdkVersion = _ext.has('compileSdkVersion') ? _ext.compileSdkVersion : 23
def _buildToolsVersion = _ext.has('buildToolsVersion') ? _ext.buildToolsVersion : '25.0.0'
def _minSdkVersion = _ext.has('minSdkVersion') ? _ext.minSdkVersion : 16
def _targetSdkVersion = _ext.has('targetSdkVersion') ? _ext.targetSdkVersion : 22

android {
    compileSdkVersion _compileSdkVersion
    buildToolsVersion _buildToolsVersion

    defaultConfig {
        minSdkVersion _minSdkVersion
        targetSdkVersion _targetSdkVersion
        versionCode 1
        versionName "1.0"
        ndk {
            abiFilters "armeabi-v7a", "x86"
        }
    }
}

dependencies {
    compile 'com.facebook.react:react-native:+'
    compile "com.mixpanel.android:mixpanel-android:5.3.0"
}
GertjanReynaert commented 6 years ago

@davodesign84 Would you mind merging/releasing this since it's blocking upgrading to react-native 56

GertjanReynaert commented 6 years ago

@davodesign84 Sorry for bothering you, but would it be possible to publish a release on NPM as well? thx!

davide-scalzo commented 6 years ago

Done :)

SunburtReynolds commented 6 years ago

Hey @davodesign84! Thanks for getting Android updated. That's a huge blocker removed from my team. 👏

Unfortunately, the most recent release (1.1.0) is broken on iOS. I've created an issue here: https://github.com/davodesign84/react-native-mixpanel/issues/151

If you can resolve this ASAP, we would be so appreciative!