davide-scalzo / react-native-mixpanel

A React Native wrapper for Mixpanel tracking
MIT License
455 stars 195 forks source link

Fix can't build on ios because of unknown type name `mixpanel` #149

Closed Kabangi closed 6 years ago

ghost commented 6 years ago

DeepCode found the following issues:

Critical: 0 Warning: 0 Info: 0

Priority breakdown:

Security Defect API Anomaly Rename Lint Info
Critical 0 0 0 0 0 0 0
Warning 0 0 0 0 0 0 0
Info 0 0 0 0 0 0 0

Most affected files:

File Critical Warning Info

See detailed analysis.

Gadigg commented 6 years ago

Can someone merge this pull request? This keeps the package from integrating with CI platforms...

ghost commented 6 years ago

DeepCode found the following issues:

Critical: 0 Warning: 0 Info: 0

Priority breakdown:

Security Defect API Anomaly Rename Lint Info
Critical 0 0 0 0 0 0 0
Warning 0 0 0 0 0 0 0
Info 0 0 0 0 0 0 0

Most affected files:

File Critical Warning Info

See detailed analysis.

lorenjohnson commented 6 years ago

Awesome. Looks like this is ready to go, thank you @Kabangi! Hopefully it'll get merged soon otherwise I'll figure out how to temporarily install the package from this branch...

SunburtReynolds commented 6 years ago

@davodesign84 do you have an ETA on when this will be merged?

davide-scalzo commented 6 years ago

Merged and published to npm :)