search

davide-scalzo / react-native-mixpanel

A React Native wrapper for Mixpanel tracking
MIT License
455 stars 195 forks source link

Mixpanel 5.6.0 #174

Closed ChrisEdson closed 5 years ago

ChrisEdson commented 5 years ago

Is there any chance we could update to the latest Mixpanel Android (5.6.0) - so that we can get FCM support?

apamphilon commented 5 years ago

Will this be as simple as updating the library in the build.gradle file or will there be more to it?

lorenc-tomasz commented 5 years ago

They moved to FCM.

apamphilon commented 5 years ago

I have followed the guide here:

https://help.mixpanel.com/hc/en-us/articles/115004706906-Google-Cloud-Messaging-GCM-Or-Firebase-Cloud-Messaging-FCM

They mention to 'update your Mixpanel library to v5.5 and above'.

I have updated the node_modules/react-native-mixpanel/android/build.gradle file to the below:

dependencies {
    compile 'com.facebook.react:react-native:+'
    compile "com.mixpanel.android:mixpanel-android:5.6.0"
}

Does anyone know if this will be sufficient or if further changes will be needed?

lorenc-tomasz commented 5 years ago

It will be. I have done it by my self. Maybe I will create PR but don't know if it has any sense as this repo is probably abandon by author.

apamphilon commented 5 years ago

@lorenc-tomasz I was thinking the exact same thing. If there is enough demand for this plugin it might be worth seeing if anyone is interested in taking it over.

lorenc-tomasz commented 5 years ago

Agree. I was thinking about it, but sadly if I get more projects I will not have time to support the module. My suggestion was to move the repo to react community but without response.

lorenc-tomasz commented 5 years ago

Have added support for 5.6.0 with link how to migrate to FCM: https://github.com/lorenc-tomasz/react-native-mixpanel/tree/fcm

lorenc-tomasz commented 5 years ago

I have created the PR here but I don't believe that somone will merge it.

kyleclegg commented 5 years ago

The upgrade to Mixpanel Android 5.6 has been merged.