Add methods add, set for Group Analytics. Only single values supported

davide-scalzo / react-native-mixpanel

A React Native wrapper for Mixpanel tracking

MIT License

455 stars 195 forks source link

Add methods add, set for Group Analytics. Only single values supported #217

Closed danactive closed 4 years ago

danactive commented 4 years ago

Closed #216

Tested with this React Native code in Android/iOS simulators

      await this.mixpanel.addGroup('company', 'mixpanel');

      await this.mixpanel.setGroup('company', 'mixpanel');

Mixpanel admin screen

ghost commented 4 years ago

DeepCode's analysis on #fbd7b2 found:

:x: 0 critical issues. :warning: 0 warnings and 0 minor issues. :heavy_check_mark: 0 issues were fixed.

:speech_balloon: This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.

:relaxed: If you want to provide feedback on our bot, here is how to contact us.

dwilt commented 4 years ago

@danactive curious, why did you have the setGroup 2nd param be a string and not an array of strings like the JS implementation does?

danactive commented 4 years ago

@dwilt My use-case only needed a single value and my deadline was tight so I did the minimum to get my job done. My design should not block another developer to add the multiple values