davide-scalzo / react-native-mixpanel

A React Native wrapper for Mixpanel tracking
MIT License
455 stars 195 forks source link

Crash when opening app #274

Open ToyboxZach opened 3 years ago

ToyboxZach commented 3 years ago

I am not sure what changed but my app started running into this issue

https://github.com/mixpanel/mixpanel-iphone/issues/937

And it looks like the solution is to just upgrade the mixpanel pod since this package is depending on 3.6 we need to bump it to 3.9

yarikpwnzer commented 3 years ago

@ToyboxZach hi, make fork from this repo, fix this line in index.js: const instance = new MixpanelInstance(apiToken, optOutTrackingDefault) to const instance = new MixpanelInstance(apiToken, optOutTrackingDefault, trackCrashes, automaticPushTracking, launchOptions) Init MP like this: Mixpanel.sharedInstanceWithToken(TOKEN, false, true, false, null)

ToyboxZach commented 3 years ago

I actually decided to switch to the mixpanel supported one, seems like a better move going forward.

I would probably suggest this package just mention the supported package now https://github.com/mixpanel/mixpanel-react-native

yarikpwnzer commented 3 years ago

@ToyboxZach oh nice, I didn't know about that. Fixed that issue all day long.