davide-scalzo / react-native-mixpanel

A React Native wrapper for Mixpanel tracking
MIT License
455 stars 195 forks source link

Ignore params on init Instance. #275

Closed yarikpwnzer closed 3 years ago

yarikpwnzer commented 3 years ago

Hello, why do You ignore params on init?

sharedInstanceWithToken(apiToken: string, optOutTrackingDefault: ?boolean = false, trackCrashes: ?boolean = true, automaticPushTracking: ?boolean = true, launchOptions: ?Object = null): Promise { const instance = new MixpanelInstance(apiToken, optOutTrackingDefault) if (!defaultInstance) defaultInstance = instance return instance.initialize() },

So You ignoring trackCrashes, automaticPushTracking (also from latest Mixpanel iOS lib should be now false), launchOptions.