davideast / angular-universal-express-firebase

A packaged Cloud Function to serve Angular Universal apps.
50 stars 9 forks source link

valueExists always returns true #5

Closed SpeedoPasanen closed 6 years ago

SpeedoPasanen commented 6 years ago

As a result, router.use(express.static(config.staticDirectory)) gets always called and crashes if staticDirectory is undefined.

function valueExists(value) { return typeof value !== 'undefined' || value !== null; }

Should return: !(typeof value === 'undefined' || value === null)

mrjmd commented 6 years ago

PR here #7.