davideast / firebase-react-native-sample

Using React Native with Firebase
786 stars 135 forks source link

Are semi-colon terminations missing on some lines? #29

Open nearodney opened 7 years ago

nearodney commented 7 years ago

The sample code in styles.js was cut and pasted into my react-native app for iOS with ES6 enabled in .babelrc. It resulted in a wasted afternoon of react-native redbox errors in my iphone simulator. The issue traced right to the styles.js file from this project. I added a few missing semi-colon line terminations with one termination per line: EACH "const" declaration line, and one termation on the first "module.exports" assignment.

Sanity was restored as a result of those fixes. Admission: I lack react-native@0.41.2 and JSX depth and understanding and probably misplaced my frustration entirely. This issue was opened to raise the question: are semi-colon line terminations missing or not?

If so, please update or caution us about styles.js. If not, please forgive my ignorance and excuse my blame shifting.