search

davidebbo / WebActivator

Apache License 2.0
242 stars 49 forks source link

Searches all subdirectories in the bin folder when compiling list of assemblies #31

Open akousmata opened 7 years ago

akousmata commented 7 years ago

This partially addresses closed issue #21; there are likely better ways of handling this, but this would be a quick fix.

xJom commented 4 years ago

Does this help when packages are installed parallell to the bin-folder? Or does it only search subfolders to the bin-folder?

davidebbo commented 1 year ago

I haven't built WebActivator in quite some years. If people feel this is important, we can get this change in, but I need to set things up to build this package again.

akousmata commented 1 year ago

To put this in context, I originally forked the code and made the change for a project at a firm I worked at 6 years ago where this was needed. It worked fine for our needs and so I PR'd. I don't use this library all that much anymore but for those that do, it might be helpful. Although, I would recommend upgrading to a more modern toolchain at this point.

davidebbo commented 1 year ago

Thanks @akousmata for the extra context. I will leave this alone unless other active users are asking for this.

Also, part of the challenge is that it targets Framework 4.0, which is no longer supported. When opening it in VS 2022, it wants to update it to 4.8, and I'm not sure what breaking effects that could have. The targeting pack for 4.0 is no longer available.

From https://learn.microsoft.com/en-us/dotnet/framework/install/guide-for-developers: Starting with Visual Studio 2022, Visual Studio no longer includes .NET Framework components for .NET Framework 4.0 - 4.5.1 because these versions are no longer supported. Visual Studio 2022 and later versions can't build apps that target .NET Framework 4.0 through .NET Framework 4.5.1. To continue building these apps, you can use Visual Studio 2019 or an earlier version.