Ignore patch number if samtools version uses it

davidebolo1993 / VISOR

VarIant SimulatOR for short, long and linked reads

GNU Lesser General Public License v3.0

41 stars 11 forks source link

Ignore patch number if samtools version uses it #24

Closed tdido closed 2 years ago

tdido commented 2 years ago

The version code fails as it doesn't expect a patch number, present in the latest samtools version in bioconda (1.15.1). This PR simply ignores it if it exists.

davidebolo1993 commented 2 years ago

Yep, thanks

tdido commented 2 years ago

Thanks for the merge. If you could generate a new release for me to package I'd appreciate it. Sorry for the bother.

davidebolo1993 commented 2 years ago

Done, thanks for working on this.

tdido commented 2 years ago

Hi again Davide.

It seems like the release didn't work as expected: it still contains the old code. Not sure how Github releases work, maybe you can't generate new code with the same tag?

davidebolo1993 commented 2 years ago

Not sure either. I'll tag with something like 1.1.0

tdido commented 2 years ago

Cool. Please make it 1.1.1 Just in case, 1.1.0 may be considered equal to 1.1.

davidebolo1993 commented 2 years ago

Sure