search

davidebolo1993 / VISOR

VarIant SimulatOR for short, long and linked reads
GNU Lesser General Public License v3.0
41 stars 11 forks source link

Compress output, centralise version declarations, and fixes #25

Closed tdido closed 2 years ago

tdido commented 2 years ago

Hey Davide.

I've made some changes to allow for the compression of the FASTQ output from SHORtS and LASeR, which would save quite a bit of space/processing power in our pipelines and hopefully would be useful to others.

I've also centralised the version declarations so you'd only need to change two files in future version updates (__init__.py and setup.py), and it would be reflected in all messages.

Finally, I've fixed the samtools version checking in SHORtS, which has the same problem we solved in 0e1b19d for LASeR.

All changes strive to minimise impact in the code, to keep code conventions, and to keep backwards compatibility.

Hope you find them useful.

davidebolo1993 commented 2 years ago

Hi @tdido,

thanks, just merged and create the new release v1.1.2 for conda.

Best,

Davide