refactor(typescript): improve roots.ts readability

davidedc / Algebrite

Computer Algebra System in Javascript (Typescript)

http://algebrite.org

MIT License

955 stars 59 forks source link

Closed brianmickel closed 3 years ago

brianmickel commented 3 years ago

Refactor control flow logic of sources/roots.ts into file-level functions and helpers.

Turn mini_solve into mini_solve + _solveDegree1 ... _solveDegree4 based on the number of coefficients of the polynomial
- (new structure best seen using an ide fold all feature)
Delete commented out code.
Use early return pattern.

risk: medium (passes existing tests, but roots.ts is a tricky file) merge: squash intended

brianmickel commented 3 years ago

I'm happy to adjust the coding style to better match the codebase and contributing.md.