refactor(Typescript): modify functions to use and return normal arguments

davidedc / Algebrite

Computer Algebra System in Javascript (Typescript)

http://algebrite.org

MIT License

968 stars 59 forks source link

refactor(Typescript): modify functions to use and return normal arguments #138

Closed brianmickel closed 3 years ago

brianmickel commented 3 years ago

Refactor several files for maintainability.

remove push and pop where possible
add a doexpand function similar to the noexpand
refactor simplify
rename variables where made obvious by comments
delete comments made redundant by variable names or nearby code
delete commented out code (visible in version control)
remove one layer of funcname, yfuncname, yyfuncname where possible

risk: medium (some code changes didn't trigger test failures) merge: squash

brianmickel commented 3 years ago

I'd be happy to re-organize the changes however is easiest for review. My motivation has been to knock out the easiest refactors for removing push, pop and moving towards more complex ones like transform.ts

davidedc commented 3 years ago

thanks @brianmickel this is great and I was exactly hoping for these sorts of refactoring to happen