Closed rumblesan closed 9 years ago
ok this should be ready to merge now
K I'll be merging the graphics parts today I hope this will still be OK to automatically merge
I just rebased onto new master. Everything appears to be working fine
grunt devbuild
works fine for me (it produces no index-dev.html file anymore, is that OK?)
but grunt releasebuild
gives me this error:
Running "git-describe:your_target" (git-describe) task
Warning: fatal: Not a git repository (or any of the parent directories): .git Use --force to continue.
Aborted due to warnings.
(I deleted the node modules directory and tried a couple of times re-installing grunt etc.)
Does it work for you?
are you running the task while in the git repo? what happens if you type git describe --tags --always --long --dirty
while you're in the repo?
no I'm not in a git repo, I've downloaded the project from github as a zip.
HSMBP-DCAS:livecodelab-42b47d1507affa0f03a7c144227ec33d6262e29b daviddellacasa$ git describe --tags --always --long --dirty
fatal: Not a git repository (or any of the parent directories): .git
aahh, that'll be the problem then. what the task does is create a file with the hash of the current git commit so that when we build if for livecodelab.net, it's easy to see exactly what's running on the site. but if you're not in a git repo, then it won't work. I'll see about adding in a check so that it won't run if you're not in a repo. that said, why did you download it instead of cloning it?
Ah I see, good idea, I'll clone it then. (I just clicked the button on the page I was looking at really).
So this creates more specific tasks for the builds. There's now a devbuild task and a releasebuild task.
These put only the necessary files in the dist folder.
Still to do