search

davidedc / livecodelab

a web based livecoding environment
http://livecodelab.net/
MIT License
327 stars 63 forks source link

Bigcleanup #255

Closed rumblesan closed 9 years ago

rumblesan commented 9 years ago

So this is a big pull request with a bunch of cleanup and formatting stuff.

a few chunks of code removed, lots of whitespace fixes, moving some things around to make everything a bit clearer.

Primarily this was just so I could get stuck back into all the code and get it back in my head again.

Tested in chrome and firefox on OSX, going to test on windows when I get a chance

davidedc commented 9 years ago

[just deleted misleading posts above]

Found one minor glitch - clicking on the "Livecodelab 2.0" box on the top-left used to bring up a small dialog, it doesn't anymore.

rumblesan commented 9 years ago

ah ha, good spot. just fixed it. I'm going to give this a go on a windows machine now. and assuming there's nothing terribly broken with it I'd like to get it merged

davidedc commented 9 years ago

cool let me know how it goes.

rumblesan commented 9 years ago

ok, Chrome on windows works just fine. both sound and visuals.

On IE11, it's not so great :( the framerate is pretty poor, hanging around 17 to 20 fps. The audio doesn't work. This does seem to be exactly the same as when running against the currently released version though, so nothing seems to be broken that wasn't already

davidedc commented 9 years ago

K if it's same as current release let's merge and take it from there then.

rumblesan commented 9 years ago

awesome, some of this will help make some of the other stuff I have in mind easier