davidedc / livecodelab

a web based livecoding environment
http://livecodelab.net/
MIT License
327 stars 63 forks source link

Webpackbuild #271

Closed rumblesan closed 7 years ago

rumblesan commented 7 years ago

So this is dependant on v2 of the language being merged. unfortunately the coffee script compiler doesn't seem to play nicely with being included :(

relevant commands

rumblesan commented 7 years ago

righty. it's now possible to select the language via an environment variable that can be set when running the npm tasks. Though currently the v2 code still gets included. The plan is that I'll start looking into optimising builds and getting dead code elimination working. That will mean that the code for the unnecessary language will be removed, probably along with a bunch of other stuff.

Check the build documentation as well and make sure it makes sense.

rumblesan commented 7 years ago

Right! had another look, and this does exactly what we were after. no need to try and do a more optimised build, this will only build with the correct language, and the files for the other version won't end up in the final build. same interface with the environment variable, just a better implementation.

I'm not sure I can think of any reasons not to merge this now @davidedc

rumblesan commented 7 years ago

so it turns out that coffee-script still needs to be included in the package.json. I'll commit that to master now. otherwise it's all looking great :D